Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve context menu action configs and UX #286

Merged
merged 8 commits into from
Feb 10, 2020
Merged

Improve context menu action configs and UX #286

merged 8 commits into from
Feb 10, 2020

Conversation

mharis001
Copy link
Member

@mharis001 mharis001 commented Jan 11, 2020 •
edited
Loading

When merged this pull request will:

  • Cleanup and improve context_actions component
  • Improve right-click context menu opening condition check - allow opening if groups of sideLogic are selected
  • Simplify context menu local scope variable names, allow _args to be defined in config

@mharis001 mharis001 added the enhancement Improves an existing feature label Jan 11, 2020
@mharis001 mharis001 added this to the 1.7.0 milestone Jan 11, 2020
@mharis001 mharis001 changed the title Improve context menu and context action configs Improve context menu action configs and UX Jan 12, 2020
CreepPork
CreepPork reviewed Jan 15, 2020
View reviewed changes
Copy link
Member

@CreepPork CreepPork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely like that the config code has been moved into separate functions, makes it far more readable and reduces code floating around.

addons/context_actions/functions/fnc_canEditInventory.sqf Outdated Show resolved Hide resolved
addons/context_actions/functions/fnc_teleportPlayers.sqf Show resolved Hide resolved
@mharis001 mharis001 mentioned this pull request Jan 19, 2020
Merged
@mharis001
Copy link
Member Author

mharis001 commented Feb 1, 2020 •
edited
Loading

Will merge after CBA 3.14.0 releases.

@mharis001 mharis001 merged commit ace2bf9 into master Feb 10, 2020
@mharis001 mharis001 deleted the context-menu-improvements branch February 10, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilzar neilzar neilzar approved these changes

@CreepPork CreepPork CreepPork approved these changes

Assignees
No one assigned
Labels
enhancement Improves an existing feature
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Improve Loadout Editing UX in a unit’s context menu
3 participants
@mharis001 @CreepPork @neilzar